Page 2 of 3

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 4:11 pm
by jb
Tex: The permissions for your user were weird. I have modified them and then tried out using the board with your user's permissions. They seem ok now ("Disable BBCode" appears in the reply page where it didn't before). Let me know if you still see weirdness. NOTE: You may see differences between forums-- I have tighter controls in the Admin forum than in the other forums, so if you see something in one place but not another that could be the cause.

KA: I googled for the "missing edit button" issue, and one suggestion indicated it might be a missing imageset. I followed the suggestion, and copied the imageset from "en" to "en_us" (so now there are both)-- let me know whether that fixed your problem.

JB

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 4:59 pm
by Manhattan Glutton
"My theme doesn't have the link!"

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 5:03 pm
by Caravan Ray
jb wrote:Tex: The permissions for your user were weird. I have modified them and then tried out using the board with your user's permissions. They seem ok now ("Disable BBCode" appears in the reply page where it didn't before). Let me know if you still see weirdness. NOTE: You may see differences between forums-- I have tighter controls in the Admin forum than in the other forums, so if you see something in one place but not another that could be the cause.

KA: I googled for the "missing edit button" issue, and one suggestion indicated it might be a missing imageset. I followed the suggestion, and copied the imageset from "en" to "en_us" (so now there are both)-- let me know whether that fixed your problem.

JB
Yes - my "edit" button has re-appeared and I can quote again. Seems to be fixed.

It all went weird when I changed my theme from Absolution to Prosilver. So I changed back to Absolution but the weirdness remained.

I am still on Absolution - but it all seems OK now.

BTW - I think the weirdness was only in this thread - not in others

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 7:15 pm
by king_arthur
Does not seem to have returned the edit button to me, even on the prosilver theme. Unless it reappears on this post, in which case I will edit it to say it has returned. FWIW, my language seems to be set to "British English," which is the only choice available under Milky Way Red. Also, as I am posting this message, the message off to the right is that BBCode is OFF and there's not a box to change that. However, it does look like quotes are now working for me.

Thanks for investigating all this.

Charles (KA)

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 7:22 pm
by king_arthur
Yeah, the only thing that seems to have started working is the appearance of quoted text in replies.

BBCode is still OFF, no "active topics" button anywhere in prosilver, can't edit or delete my own posts, even ones I did since the changes you made. I clicked the "delete all songfight cookies" button and logged back in, that didn't seem to fix it either.

Charles (KA)

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 7:37 pm
by jb
See if that's fixed it, Charles. I dunno why you guys' users had your permissions reset like that. Maybe it had something to do with switching themes, but that would be really weird.

JB

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 7:48 pm
by Caravan Ray
king_arthur wrote: FWIW, my language seems to be set to "British English"
Could everyone's be set to that please? I am sick of correcting everybody's spelling mistakes

Re: NEW: Fight Review-o-matic!

Posted: Thu Jan 05, 2012 10:48 pm
by JonPorobil
Hey JB, would it be possible to get the "Review This Fight" link onto the other themes? I don't mean to start a Theme War, but I use subsilver2 because I find prosilver to be unusably disorienting (who wants the avatars on the [i]right[/i] side of the screen, anyway?). If you can't, it's not a big deal, but there's only four other themes, and if it's trivial to paste the same script into each of them, then I think those of us who use alternate themes would be quite grateful.

Re: NEW: Fight Review-o-matic!

Posted: Fri Jan 06, 2012 4:23 am
by jast
Just chiming in to say that the "disable BBCode" checkbox has disappeared for me without switching themes. And I guess the edit/delete buttons are gone, too — if this sentence stays here, you know that they are.

Re: NEW: Fight Review-o-matic!

Posted: Fri Jan 06, 2012 6:59 am
by king_arthur
I am now seeing the "edit" and "delete" buttons on my posts, and underneath the block where I'm typing, there are buttons to disable it. Quote blocks are behaving as they should. When I first logged on, I was pretty sure there was a "view active posts" link, but now I can't find it...

So whatever you did, I think it mostly fixed me up. Thanks!

Charles (KA)

EDIT :-) : I still cannot find the "view active topics" link on the prosilver theme, but on Milky Way Red it is there, in a little block right below the "Board Index" block near the top of the page. It's always there, whether I'm browsing, editing, posting, whatever - it's a set of text links, no icons involved.
screen shot, MWR theme with "active topics" link
screen shot, MWR theme with "active topics" link
MWR.jpg (57.15 KiB) Viewed 7308 times

Re: NEW: Fight Review-o-matic!

Posted: Fri Jan 06, 2012 7:22 am
by jb
PHPBB is aggravating.

Well, I guess it's fine if you never change anything.

Harrumph. Ok guys, I'll work on it. Quality control issues should go in the Quality control thread though please.

JB

Re: NEW: Fight Review-o-matic!

Posted: Sun Jan 08, 2012 8:05 am
by Paco Del Stinko
So now, the Review-O-Matic is opening when I click the link. Very nice! Also, I noticed on a page that Caravan Ray had written on, that a little expand tab appeared on the bottom left of my sceen. I clicked it, and it was his Pull My Finger signature. Of course I pulled. Anyway, was that feature intended? (Not his "poot")

Re: NEW: Fight Review-o-matic!

Posted: Sun Jan 08, 2012 12:32 pm
by Billy's Little Trip
I don't see "Review This Week's Fight" at the top of my page.

Re: NEW: Fight Review-o-matic!

Posted: Sun Jan 08, 2012 1:02 pm
by Billy's Little Trip
Billys Little Trip wrote:I don't see "Review This Week's Fight" at the top of my page.

edit: Never mind. I see it before I log in on the front page. But it goes away when I log in. So I switched from subsilver2 to the prosilver theme on the front page, and it's up there as described.

But I am quoting myself because my edit button is gone, lol. I'll just sign in after I click the "Review This Week's Fight" and keep my subsilver2 theme. ....thinking out loud and assuming it will work that way. We'll get there. ;)

Re: NEW: Fight Review-o-matic!

Posted: Sun Jan 08, 2012 6:37 pm
by jb
Check on other threads before you decide. This admin announcement thread is special and people have fewer permissions here.

I am also looking at other themes, 'cause prosilver is blech. Well, all the free ones are blech but there are a couple that are not awful.

JB

Re: NEW: Fight Review-o-matic!

Posted: Sun Jan 08, 2012 6:53 pm
by Spud
subsilver2 is the only theme worth using.

Re: NEW: Fight Review-o-matic!

Posted: Mon Jan 09, 2012 9:39 am
by Billy's Little Trip
Yeah you're right. It's only in this thread that my edit isn't available. Prosilver is ok, but it would take me a while to get used to everyone's avatar and info on the right. It's like retraining yourself to read a book right to left, lol.

Other than that, the new "review this fight" addition is pretty cool. Is there a way to have a tag for it on the song list page. The page with the 400X400 cover art?

Re: NEW: Fight Review-o-matic!

Posted: Mon Jan 09, 2012 10:05 am
by jb
I'll be adding the code to more themes. Seems Spud uses subsilver2, so I'll likely add it to that one. And I downloaded another theme to try out that's cleaner. May make that the default theme and "deprecate" prosilver.

It's up to Spud if he wants to link to the reviewer thing from sf.org. If the user is not a member of the boards it won't work for them, and if they're not using a theme it's installed on it won't pre-populate the fight. HOWEVER, it will open a "reply" post for the correct review thread, rather than just going to the thread itself. Doesn't work for the archive, only the current fight.

JB

Re: NEW: Fight Review-o-matic!

Posted: Mon Jan 09, 2012 12:29 pm
by JonPorobil
Sounds great, jb. Awesome work.

After all, we love and appreciate our fightmasters around here, right guys?

Re: NEW: Fight Review-o-matic!

Posted: Tue Jan 10, 2012 10:43 am
by HeuristicsInc
of course we do!

Re: NEW: Fight Review-o-matic!

Posted: Tue Jan 17, 2012 11:11 am
by jb
This now works for subsilver2.

JB

Re: NEW: Fight Review-o-matic!

Posted: Tue Jan 17, 2012 11:47 am
by Manhattan Glutton
Awesome. Although, the title is "= The Song Fight Bulletin Board"
I can live with this, though.