Issues with multiple entries in one fight by same artist
Posted: Fri Sep 14, 2018 10:14 pm
Background info: While we ask folks not to enter more than one song in a fight, we don't prevent it. It's happened a couple times. It turns out this situation causes a variety of issues.
The most egregious issue is that votes are only cast at the band level, not the mp3 URL level. So all votes for any of the multiple entries by a band get added together into one vote total for that band. This issue is difficult to resolve because of how the voting information is stored and parsed. It's already very complex and brittle and adding another dimension to it to track mp3 URL level information will take a lot of tricky work and will probably involve breaking things (badly) for a while.
Another issue is that the archive is counting every entry in the fight as a win, so, enter two songs and win, you get two wins, enter three songs and win, you get three wins, etc. It seems like folks think of "wins" as being "fights won" not "sum of the number of songs entered in fights won". This second problem is potentially simpler to deal with as it may just involve small tweaks to how wins are counted to switch the counts to be "fights won".
I'm going to dip my toes into addressing the second issue now. I've got it fixed on the individual artist page. It's going to take me a while though to track down everywhere where win counting is done and update every page.
You can see the effects here on the Glennny and BSS artist archive pages. At the bottom of the page, the number of wins shown is now the number of fights won. Two less for Glennny and one less for BSS than before, when Glennny's three songs for "My Last Nerve" were counted three times and BSS's two songs for "Young Blood" were counted twice.
http://www.songfight.org/artistpage.php ... rtkey=date
http://www.songfight.org/artistpage.php ... rtkey=date
The Jukebox also counts wins by number of songs in fights won, so, I'll have to do some tweaking over there too but due to a laptop transition I'm not set up to update that app very easily yet, and it's of secondary importance anyway.
The most egregious issue is that votes are only cast at the band level, not the mp3 URL level. So all votes for any of the multiple entries by a band get added together into one vote total for that band. This issue is difficult to resolve because of how the voting information is stored and parsed. It's already very complex and brittle and adding another dimension to it to track mp3 URL level information will take a lot of tricky work and will probably involve breaking things (badly) for a while.
Another issue is that the archive is counting every entry in the fight as a win, so, enter two songs and win, you get two wins, enter three songs and win, you get three wins, etc. It seems like folks think of "wins" as being "fights won" not "sum of the number of songs entered in fights won". This second problem is potentially simpler to deal with as it may just involve small tweaks to how wins are counted to switch the counts to be "fights won".
I'm going to dip my toes into addressing the second issue now. I've got it fixed on the individual artist page. It's going to take me a while though to track down everywhere where win counting is done and update every page.
You can see the effects here on the Glennny and BSS artist archive pages. At the bottom of the page, the number of wins shown is now the number of fights won. Two less for Glennny and one less for BSS than before, when Glennny's three songs for "My Last Nerve" were counted three times and BSS's two songs for "Young Blood" were counted twice.
http://www.songfight.org/artistpage.php ... rtkey=date
http://www.songfight.org/artistpage.php ... rtkey=date
The Jukebox also counts wins by number of songs in fights won, so, I'll have to do some tweaking over there too but due to a laptop transition I'm not set up to update that app very easily yet, and it's of secondary importance anyway.