Page 1 of 3

Fixing typos in the archive data

Posted: Sun Sep 15, 2019 11:42 am
by Lunkhead
"Possom Sauce" and "Phillipsox" are now fixed. The songs from those artists have been merged into the correct artists. The Jukebox is updated now. The official archive data has been fixed but the site won't be updated until the next time I update the site with the next results/title/fight.

If you have any other requests about fixing typos with artist names etc. in the archive please post them here.

Re: Fixing typos in the archive data

Posted: Wed Sep 18, 2019 1:44 pm
by Lunkhead
I just noticed this in the 15 years ago on the homepage:

http://www.sfjukebox.org/artists/R.%20M ... 20Ensemble

"Mostquito"??? I don't know if it's a great idea for me to tamper with data from that far back but ... that has GOT to be a typo, right?

Re: Fixing typos in the archive data

Posted: Wed Sep 18, 2019 5:53 pm
by jb
it's not a Hostess Mostess/Reve Mosquito collab is it?

Re: Fixing typos in the archive data

Posted: Wed Sep 18, 2019 8:37 pm
by Lunkhead
Reve Mosquito and Blind Mime Ensemble collab I would guess.

Re: Fixing typos in the archive data

Posted: Thu Sep 19, 2019 1:08 pm
by Pigfarmer Jr
Lunkhead wrote:
Wed Sep 18, 2019 1:44 pm
that has GOT to be a typo, right?
Doesn't matter either way. It's part of our history now, you simply CANNOT change it. Tradition, dude.

Re: Fixing typos in the archive data

Posted: Fri Sep 20, 2019 6:12 am
by ujnhunter
It is a typo. Reve Mosquito.

Re: Fixing typos in the archive data

Posted: Fri Sep 20, 2019 8:12 am
by ken
ujnhunter wrote:
Fri Sep 20, 2019 6:12 am
It is a typo. Reve Mosquito.
I dunno. I'm with PJr on this one.

Re: Fixing typos in the archive data

Posted: Tue Dec 10, 2019 1:27 pm
by Toshiro
Could you change every TOSHIRO to Toshiro? Or possibly toshiro. Or toshiro

Re: Fixing typos in the archive data

Posted: Tue Dec 10, 2019 2:16 pm
by Lunkhead
Yes, eventually. I'm about to head out of town and may not get to it till I get back in a week. A change like that will probably take me 20-30 minutes mucking about with text files and databases.

Just curious, was "TOSHIRO" incorrect back in 2011? Or have you changed how you want it to look since then?

http://sfjukebox.org/artists/TOSHIRO

Re: Fixing typos in the archive data

Posted: Wed Dec 11, 2019 11:51 am
by Toshiro
I think it was incorrect, but it was 8 years ago, maybe I just shouted a lot back then.

Re: Fixing typos in the archive data

Posted: Wed Dec 18, 2019 11:20 pm
by Lunkhead
OK Toshiro, you should be all set now. Hopefully I found all the places that needed to be changed.

Re: Fixing typos in the archive data

Posted: Sat Dec 21, 2019 2:31 pm
by Æpplês&vØdkã
This may seem like an oddball request, but: there's an artist in the archive under the name of "?". That was me!

I recall back then I was actually trying to submit songs under the name "ö" and for whatever reason the Fightmaster at the time couldn't get it to work right. Is there any way that ? could be corrected to ö now?

Re: Fixing typos in the archive data

Posted: Sat Dec 21, 2019 2:43 pm
by Lunkhead
Wow! That is going back a ways. I think it ought to be possible to rename that artist to "ö" nowadays. It's likely though that I won't get to it for a week or two due to the holidays.

Re: Fixing typos in the archive data

Posted: Sat Dec 21, 2019 3:03 pm
by Æpplês&vØdkã
Yeah, I think that was what I originally wanted to use as my artist name for a good while, but for some reason the umlaut kept causing problems. So I just entered under a whole slew of monikers for a couple years before I finished high school and more or less neglecting the place for a decade and change... Thanks for looking into it!

Re: Fixing typos in the archive data

Posted: Sat Dec 21, 2019 4:24 pm
by Toshiro
Thanks for the change!

Re: Fixing typos in the archive data

Posted: Wed Mar 11, 2020 12:00 am
by crumpart
I’ve just noticed that the dates are skewiff for the last couple of fights in the archive. The first number (is that Month in US date parlance?) isn’t showing up and there are two slashes before the year. Attempting to attach a screenshot for reference.

Re: Fixing typos in the archive data

Posted: Wed Mar 11, 2020 6:09 am
by sleepysilverdoor
I'm flattered!

And yes, we do mm/dd/yy for some reason here. It's never been very intuitive

Re: Fixing typos in the archive data

Posted: Wed Mar 11, 2020 8:00 am
by Lunkhead
That is very weird. Seems like it only effects the artist pages in the archive? Fight pages and list pages seem OK. I'll take a look. Thanks for letting me know.

Re: Fixing typos in the archive data

Posted: Wed Mar 11, 2020 8:28 am
by vowlvom
I know it's not a songfight-hosted page, but the dates are wrong on the review-o-matic for some of the recent fights as well. But I don't think they were wrong until Tricked For The Last Time was posted. This probably doesn't help!

Re: Fixing typos in the archive data

Posted: Wed Mar 11, 2020 8:37 am
by Lunkhead
I've found the issues. Turns out some of the 20 year old songfight code handles dates by parsing them based on the positions of the numbers, and expects only 2-digit years. I recently made a change to the Jukebox, to an admin page I use to generate one of the files involved in updating Song Fight. The change was to prepopulate a couple of date fields. Turns out I'm prepopulating them with 4-digit years, and so those are going into the archive data and that's messing things up. Aargh. This is why to never ever ever ever use 2-digit years folks. A lesson most programmers learned 20+ years ago. I won't have time to sort all the cleanup out this morning, I'll have to do it tonight.

Re: Fixing typos in the archive data

Posted: Wed Mar 11, 2020 9:02 pm
by Lunkhead
I think I've managed to clean this up, and I changed my Jukebox tool that introduced the 4-digit years to operate only with 2-digit years.

Re: Fixing typos in the archive data

Posted: Wed Mar 11, 2020 10:38 pm
by crumpart
Thanks! We noticed it the other night while out at dinner trying to convince a friend to Songfight, and made a mental note to mention it.