Page 1 of 1
Broken artist pages
Posted: Sat Jul 02, 2011 6:18 pm
by Manhattan Glutton
<3
<3 wrote:Fatal error: Allowed memory size of 94371840 bytes exhausted (tried to allocate 1025 bytes) in /home/fightmaster/songfight.org/artistpage.php on line 100
And then these are most likely because the last fight hasn't been integrated yet. Infinite loops:
uncomfortable_project
billys_little_stinko
Re: Broken artist pages
Posted: Sun Jul 03, 2011 10:02 am
by Spud
Manhattan Glutton wrote:<3
<3 wrote:Fatal error: Allowed memory size of 94371840 bytes exhausted (tried to allocate 1025 bytes) in /home/fightmaster/songfight.org/artistpage.php on line 100
And then these are most likely because the last fight hasn't been integrated yet. Infinite loops:
uncomfortable_project
billys_little_stinko
FIXED. You were right as to the cause.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 10:39 am
by Manhattan Glutton
The artist page for "<3" still broken.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 11:28 am
by Spud
what can I say. It's almost like the band name was created to break html.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 4:26 pm
by Lunkhead
Character encoding is problematic in the archive data and on the site, sadly, but you may have better luck with
http://sfjukebox.org/artists/<3 (PHPBB thinks the "<" is the end of the link, but if you copy the whole thing and paste it into your browser's URL bar, it'll work).
Re: Broken artist pages
Posted: Sun Jul 03, 2011 6:40 pm
by fluffy
http://sfjukebox.org/artists/%3c3
What's so hard about URL-encoding your URLs? Jeeze, people.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 7:24 pm
by Manhattan Glutton
What's so hard about having normal bandnames? Some people are going to face a harsh reality when the wiki goes live.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 7:36 pm
by fluffy
I am sure that the person behind <3 doesn't give a crap about being wiki-able.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 7:42 pm
by Manhattan Glutton
Irony.
fluffy -> Fluffy
So<kpupp3t -> SoCkpupp3t
Re: Broken artist pages
Posted: Sun Jul 03, 2011 7:46 pm
by Manhattan Glutton
You know, fluffy, it's funny how many weird quirks in the archive you are directly responsible for. Like that one fight you submitted 3 songs to.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 7:57 pm
by fluffy
Sorry for experimenting.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 7:58 pm
by Manhattan Glutton

You're only getting one precreated wiki page for liner notes on that one. Sorry.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 8:01 pm
by fluffy
That's fine. If you listen to the songs you'll probably get a better appreciation for what the experiment was.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 10:45 pm
by Lunkhead
I purposely did not encode it, to show that it worked, in spite of PHPBB's mishandling of it. Presumably browsers encode it before they request it, so we the users do not have to. What's so hard about reading exactly what I wrote as being exactly what I meant to write?

Re: Broken artist pages
Posted: Sun Jul 03, 2011 11:01 pm
by fluffy
Depends on the browser, and technically changing the URL automatically is sorta-broken behavior. Firefox and Chrome both display the decoded URL in the address bar, which is IMO a different kind of broken, of the "I'M HELPING!!!" sort.
Re: Broken artist pages
Posted: Sun Jul 03, 2011 11:15 pm
by Lunkhead
I'm content with it working in Firefox, Chrome, and Safari (don't have Windows handy to test IE and don't care about Opera, call me when their market share breaks 10%). I URL encode artist names in all the links on my site but I try never to show the encoded names in the text on the pages. Please find me somewhere where that is not the case so I can fix it.
Of course, I can still have issues when somebody's band name is actually "So<kpupp3t" in the archive data (the autocomplete JavaScript I use encodes the & unfortunately so users still see "So<kpupp3t" instead of "So<kpupp3t").
Anyway, the bottom line is, the archive is kind of f'd up.

Re: Broken artist pages
Posted: Sun Jul 03, 2011 11:21 pm
by fluffy
Lunkhead wrote:I'm content with it working in Firefox, Chrome, and Safari (don't have Windows handy to test IE and don't care about Opera, call me when their market share breaks 10%). I URL encode artist names in all the links on my site but I try never to show the encoded names in the text on the pages. Please find me somewhere where that is not the case so I can fix it.
I was only commenting on the broken phpBB link and ranting in general about how a lot of PHP-based sites are written by people who don't understand (or care about) the difference between URL, HTML, and plaintext encoding.
I suspect that the problem with <3 on the archive is that the archive filename is probably trying to be actually named <3.html or something and that's of course not a valid UNIX filename. There's so much code in the Song Fight archive system that's all ad-hoc and screwy and full of short-term hacks that I'm kind of surprised this issue hasn't come up sooner, frankly. (Also, to be fair, the artist page caching thing is something I wrote, as a short-term hack to reduce the server load, and I didn't really think things through, because Dreamhost was getting ready to kick songfight.org off for using too many server resources and so on.)
Unfortunately I seem to have forgotten the server admin password, or maybe JB changed it again without letting me know. So I can't investigate/fix the problem myself. Sigh.
Re: Broken artist pages
Posted: Wed Jul 06, 2011 9:49 pm
by Spud
fluffy wrote:There's so much code in the Song Fight archive system that's all ad-hoc and screwy and full of short-term hacks...
fluffy wrote:the artist page caching thing is something I wrote, as a short-term hack...
Pot to Kettle: what, you think I do this for a living?
Re: Broken artist pages
Posted: Wed Jul 06, 2011 10:21 pm
by fluffy
Yeah, I know. Lots of the ad-hoc screwiness is from my own attempts at keeping the site working with short-term fixes until someone gets around to rewriting the site code in a reasonable way, which is something that never happens because nobody does it for a living.
I don't think I ever specifically said that the problems were all from YOUR short-term hacks or anything, but if I did, I apologize.